aws-vpc-cni: move default affinity to values.yaml #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows you to override the affinity, should you want to, using the already existing `affinity` key in the Helm values. Previously, setting the `affinity` key in the Helm values would cause a duplicate `affinity` key in the pod spec.
fawadkhaliq
pushed a commit
that referenced
this pull request
Jan 8, 2021
This reverts commit e69602c.
fawadkhaliq
pushed a commit
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you to override the affinity, should you want to, using the already existing
affinitykey in the Helm values.Previously, setting the
affinitykey in the Helm values would cause a duplicateaffinitykey in the pod spec. This might have worked, but I think it would be dependent on the YAML parserBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.