Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-sigv4-proxy-admission-controller] add admissionReviewVersions to webhook #489

Merged
merged 1 commit into from Mar 30, 2021
Merged

[aws-sigv4-proxy-admission-controller] add admissionReviewVersions to webhook #489

merged 1 commit into from Mar 30, 2021

Conversation

kishorj
Copy link
Contributor

@kishorj kishorj commented Mar 30, 2021 •
edited

Issue

Fix aws-sigv4-proxy-admission-controller webhook, changes introduced in #456

Description of changes

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Verified chart can be installed/uninstalled on k8s 1.19

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@achevuru achevuru self-requested a review March 30, 2021 22:49
@kishorj kishorj merged commit 969b0c0 into aws:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achevuru achevuru achevuru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kishorj @achevuru