Added elasticsearch.suppressTypeName to values.yaml to support settin… #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Suppress_Type_Name for Opensearch 2.0 and above
codesometech
requested review from
PettitWesley and
hossain-rayhan
as code owners
PettitWesley
approved these changes
Dec 19, 2022
PettitWesley
previously requested changes
Dec 19, 2022
There was a problem hiding this comment.
@codesometech Do you know how I can check that the template renders properly without actually deploying it. Currently the following is failing for me:
147dda285fd4:aws-for-fluent-bit wppttt$ helm template --dry-run .
Error: template: templates/psp.yaml:4:11: executing "templates/psp.yaml" at <include "aws-for-fluent-bit.fullname" .>: error calling include: template: no template "aws-for-fluent-bit.fullname" associated with template "gotpl"
Use --debug flag to render out invalid YAML
147dda285fd4:aws-for-fluent-bit wppttt$ helm template --dry-run --debug .
install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/wppttt/logging-projects/eks-charts/stable/aws-for-fluent-bit
Error: template: templates/psp.yaml:4:11: executing "templates/psp.yaml" at <include "aws-for-fluent-bit.fullname" .>: error calling include: template: no template "aws-for-fluent-bit.fullname" associated with template "gotpl"
helm.go:84: [debug] template: templates/psp.yaml:4:11: executing "templates/psp.yaml" at <include "aws-for-fluent-bit.fullname" .>: error calling include: template: no template "aws-for-fluent-bit.fullname" associated with template "gotpl"
147dda285fd4:aws-for-fluent-bit wppttt$ helm template aws-for-fluent-bit
Error: non-absolute URLs should be in form of repo_name/path_to_chart, got: aws-for-fluent-bit
147dda285fd4:aws-for-fluent-bit wppttt$ helm template aws-for-fluent-bit .
Error: template: templates/psp.yaml:4:11: executing "templates/psp.yaml" at <include "aws-for-fluent-bit.fullname" .>: error calling include: template: no template "aws-for-fluent-bit.fullname" associated with template "gotpl"
Use --debug flag to render out invalid YAML
147dda285fd4:aws-for-fluent-bit wppttt$ helm template aws-for-fluent-bit --generate-name .
Error: cannot set --generate-name and also specify a name
147dda285fd4:aws-for-fluent-bit wppttt$ helm template --generate-name .
Error: template: templates/psp.yaml:4:11: executing "templates/psp.yaml" at <include "aws-for-fluent-bit.fullname" .>: error calling include: template: no template "aws-for-fluent-bit.fullname" associated with template "gotpl"
Use --debug flag to render out invalid YAML
PettitWesley
dismissed
their stale review
don't want to block since I don't know what i'm doing just revoking my previous approval
|
helm template --dry-run . --set elasticsearch.enabled=true --set elasticsearch.suppressTypeName="On" That command works fine for me. I am able to generate the template successfully |
|
@codesometech Thanks! That command works for me and I see that the supress_type_name option is set. |
PettitWesley
reviewed
Jan 4, 2023
| @@ -94,6 +94,7 @@ helm delete aws-for-fluent-bit --namespace kube-system | |||
| | `elasticsearch.port` | TCP Port of the target service. | 443 | | |||
| | `elasticsearch.retryLimit` | Integer value to set the maximum number of retries allowed. N must be >= 1 | 6 | | |||
| | `elasticsearch.replaceDots` | Enable or disable Replace_Dots | On | | |||
| | `elasticsearch.suppressTypeName` | OpenSearch 2.0 and above needs to have type option being removed by setting Suppress_Type_Name On | | | |||
There was a problem hiding this comment.
So there's no default value for this, so if not specificied, its just not in the template?
There was a problem hiding this comment.
I checked this myself with the helm dry run command
PettitWesley
approved these changes
Jan 4, 2023
|
Thanks! |
|
I'm gonna merge it... I checked dry run template command shown above + run the command without new option, both run without error. So I think this is safe 🤞🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g Suppress_Type_Name for Opensearch 2.0 and above
Issue
#861
Description of changes
Added suppressTypeName to aws-for-fluent-bit's values.yaml and changed configmap template to include Suppress_Type_Name if a value is present.
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Manually tested including and excluding the value and deployed the chart on an EKS cluster
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.