Enable Prometheus metrics without service monitor in aws-load-balancer-controller #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashcr
force-pushed
the
enable-prometheus-metrics-without-service-monitor
branch
from
fd1991a
to
7e0bf65
Compare
Open
6 tasks
|
I just realized this chart is a mirror of https://github.com/kubernetes-sigs/aws-load-balancer-controller so I duplicated the issue and PR there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#959
Description of changes
Add a
metrics.enabledvariable in aws-load-balancer-controller to create the Prometheus metrics service independently of the service monitor. This enables monitoring for EKS clusters that are using alternative Prometheus collectors and don't have Prometheus Operator/ServiceMonitor CRD installed.Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
I ran
helm lint,helm templateand verified the outputs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.