Use templater to generate prowjobs #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/override prowjobs-lint-presubmit The lint prowjob will fail on this PR since I'm moving the lint code to a separate |
|
@abhay-krishna: Overrode contexts on behalf of abhay-krishna: prowjobs-lint-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override prowjobs-lint-presubmit |
|
@abhay-krishna: Overrode contexts on behalf of abhay-krishna: prowjobs-lint-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
abhay-krishna
force-pushed
the
template-pj
branch
2 times, most recently
from
4a4ad39
to
64a0b41
Compare
abhay-krishna
commented
Dec 30, 2021
abhay-krishna
force-pushed
the
template-pj
branch
5 times, most recently
from
69bacf5
to
ace0ee7
Compare
abhay-krishna
force-pushed
the
template-pj
branch
8 times, most recently
from
0c655fa
to
2e54e04
Compare
abhay-krishna
force-pushed
the
template-pj
branch
2 times, most recently
from
90f45c0
to
5401206
Compare
abhay-krishna
force-pushed
the
template-pj
branch
5 times, most recently
from
21c33a0
to
0f8ab00
Compare
|
@jaxesn I've resolved your comments for the most part, except the make targets. I will do that in a follow-up to this after modifying the make targets in the respective repos. |
abhay-krishna
force-pushed
the
template-pj
branch
2 times, most recently
from
12931fb
to
1fd3441
Compare
|
/test prowjobs-lint-presubmit |
abhay-krishna
force-pushed
the
template-pj
branch
from
1fd3441
to
0fcd477
Compare
abhay-krishna
force-pushed
the
template-pj
branch
from
0fcd477
to
7dab2db
Compare
abhay-krishna
force-pushed
the
template-pj
branch
from
7dab2db
to
ad04d0d
Compare
abhay-krishna
force-pushed
the
template-pj
branch
from
ad04d0d
to
f0c5577
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna, jaxesn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@abhay-krishna: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to generate Prowjobs using Go templater using standard templates based on job types, with additional fields added based on configuration. Now any Prowjob can be defined using a set of common options defined here, which can be expanded if desired.
/hold
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.