Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off auto garbage collection to help with big patches #604

Merged
merged 3 commits into from
May 10, 2024

Conversation

markapruett
Copy link
Member

Issue #, if available:

Description of changes:
We recently added a big patch that vendored deps, which caused the clean up command to fail because the .git file was still in use likely due to a race between the git gc and clean up of some huge patch files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markapruett
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markapruett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 558b0d0 into aws:main May 10, 2024
2 checks passed
@eks-distro-bot
Copy link
Collaborator

@markapruett: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eks-distro-attribution-periodics.yaml using file jobs/aws/eks-distro/eks-distro-attribution-periodics.yaml

In response to this:

Issue #, if available:

Description of changes:
We recently added a big patch that vendored deps, which caused the clean up command to fail because the .git file was still in use likely due to a race between the git gc and clean up of some huge patch files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants