Bumped to Kubernetes 1.26.0 #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
patch
markapruett
reviewed
Jan 19, 2023
|
/hold |
markapruett
approved these changes
Jan 20, 2023
jaxesn
reviewed
Jan 20, 2023
| @@ -0,0 +1,32 @@ | |||
| From cba455c311dc281180dd3854e7e30dfb9ca80a01 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Is this needed? I just tried running a build locally (didnt let it finish since it takes too long) but it seemed to get going. Im curious if you dug into to why/if this is still necessary?
There was a problem hiding this comment.
i see it actually, not sure why i didnt get it the first time, but ill open a pr
Co-authored-by: Mark Pruett <67116121+markapruett@users.noreply.github.com>
kschumy
force-pushed
the
kubernetes-1.26-plz-work
branch
from
c7faf56
to
c2a2171
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kschumy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
markapruett
approved these changes
Jan 24, 2023
Closed
danbudris
pushed a commit
to danbudris/eks-distro
that referenced
this pull request
Sep 25, 2023
* Bumped to 1.26.0 * Added placeholder patch to fix build * possibly fix 'make generated_files' is deprecated error * Add conditional for build * Update projects/kubernetes/kubernetes/build/lib/binaries.sh Co-authored-by: Mark Pruett <67116121+markapruett@users.noreply.github.com> * Added conditional for heketi vendor * added make generated_files back for <= 1.23 * Checksums * removed placeholder patch * you already know Co-authored-by: Mark Pruett <67116121+markapruett@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.