Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed outdated user section in docs #776 #1920

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Removed outdated user section in docs #776 #1920

merged 3 commits into from
Apr 24, 2023

Conversation

notamyth
Copy link
Contributor

Removed outdated user section in docs #776

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@notamyth
Removed outdated user section in docs aws#776
c5ed129 
Removed outdated user section in docs aws#776
@eks-distro-bot
Copy link
Collaborator

Hi @notamyth. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 11, 2023
@notamyth
Copy link
Contributor Author

/assign @rothgar

@rothgar
Copy link
Contributor

rothgar commented Apr 11, 2023

These files are still referenced in the users file. Should they be removed there? https://github.com/aws/eks-distro/blob/main/docs/contents/users/index.md

@notamyth
Removed Build references from users page
35eecb8 
Removed Build references from users page
@rothgar
Copy link
Contributor

rothgar commented Apr 11, 2023

/ok-to-test

@notamyth
removed build references from contents page and mkdocs file
6428ed4 
removed build references from contents page and mkdocs file
@notamyth
Copy link
Contributor Author

/retest

@abhay-krishna
Copy link
Member

/hold

@kschumy
Copy link
Contributor

kschumy commented Apr 11, 2023

@notamyth we're about to merge some important docs changes, so we're going to pause on merging this PR at this time. We'll come back to it as soon as we can, likely tomorrow or sometime later this week.

And thank you for your contribution!!

@kschumy
Copy link
Contributor

kschumy commented Apr 21, 2023

/retest

@kschumy
Copy link
Contributor

kschumy commented Apr 24, 2023

/lgtm

@kschumy
Copy link
Contributor

kschumy commented Apr 24, 2023

@notamyth if you're ready to merge these changes, please add /approve to merge it.

Thank you again for your contribution! We'll recognize your help in the next release's changelog

@notamyth
Copy link
Contributor Author

/approve

@kschumy
Copy link
Contributor

kschumy commented Apr 24, 2023

/unhold

@kschumy
Copy link
Contributor

kschumy commented Apr 24, 2023

well apparently I need to approve this too

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kschumy, notamyth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit b89377e into aws:main Apr 24, 2023
3 checks passed
@kschumy kschumy mentioned this pull request Jul 6, 2023
Closed
danbudris pushed a commit to danbudris/eks-distro that referenced this pull request Sep 25, 2023
@notamyth @danbudris
Removed outdated user section in docs aws#776 (aws#1920)
c113e23 
* Removed outdated user section in docs aws#776

Removed outdated user section in docs aws#776

* Removed Build references from users page

Removed Build references from users page

* removed build references from contents page and mkdocs file

removed build references from contents page and mkdocs file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kschumy kschumy

Labels
approved documentation Improvements or additions to documentation lgtm ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@notamyth @eks-distro-bot @rothgar @abhay-krishna @kschumy