Fixing shortcut expansion bug caused by equality comparison between InputByte and InputMultiByteSet #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The bug occurred when a shortcut transition existed, then an equals-ignore-case rule gets added and tries to expand the shortcut. This logic involves an equals comparison between each InputCharacter from the original value added and the current value added. This occurs on ByteMachine line 1402. Since a shortcut transition came from an exact match, it will be represented by InputBytes, where as the equals-ignore-case match will be represented by InputMultiByteSets. This means the equality check will always return false. I considered changing the equality checks to allow a single byte InputMultiByteSet to equal an InputByte, but that would be a misleading equals implementation. Instead, I changed the equals-ignore-case parser to parse into InputBytes when lower and upper case representations are the same.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.