Performance improvements on the addPattern code path. Avoiding lots of unnecessary Set creations. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f unnecessary Set creations.
|
is the performance high enough to update the number within the readme ? |
The performance improvement is just during machine creation, but not during matching. I don't think we have machine creation latency numbers in the README? |
|
oh you're right. Odd that we don't have a benchmark for this. Feels like a miss. Worth an issue? |
Sure. #105 |
baldawar
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Main strategy was turning SingleByteTransition into an Iterable of itself, and then changing many methods that returned Sets to return Iterables, so that in the n=1 case, we can return a SingleByteTransition instead of a single-element set and avoid the set creation. Also, revised updateTransition in ByteMap to work on the same TreeMap instead of creating a replacement.
In my testing, this gives up to a 25% reduction in GC activity, and a 50% reduction in machine creation latency at p99.9.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.