Bringing Ruler packages back in sync #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudygt
reviewed
Oct 6, 2023
| @@ -91,7 +90,7 @@ Set<NameStateWithPattern> transitionOn(String valString) { | |||
| boolean fieldValueIsNumeric = false; | |||
| if (hasNumeric.get() > 0) { | |||
| try { | |||
| final double numerically = JavaDoubleParser.parseDouble(valString); | |||
There was a problem hiding this comment.
can we keep our version here, I am pretty sure this one is faster than the standar double parser
There was a problem hiding this comment.
Hey Rudy,
that's a good catch. let me double check the benchmark numbers. I thought JavaDoubleParser was faster too. I'll will respond on Tuesday (away until then).
There was a problem hiding this comment.
I don't see any regressions or improvements within the benchmarks because most of the time is spent in ComparableNumber but when testing in isolation against the numbers within the benchmark data, I see this FastDoubleParser to be slightly better (45 seconds vs 50 seconds). Added it back for now.
jonessha
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Both packages had bifurcated when wildcard and ruler internal improvements were happening in parallel. Aligning code-bases before move everyone to the OSS version under the cover.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.