Support for prefix/equals-ignore-case and suffix/equals-ignore-case #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 23, 2023 11:51
* Adding functionality for prefix/equals-ignore-case and suffix/equals-ignore-case with the respective unit tests, benchmarks, and README updates.
* Explicitly running the benchmarks class after mvn verify is executed. By default, the maven-surefire-plugin only runs tests with the "Test" which ends up ignoring the Benchmarks test class.
After adding the "Run benchmarks" step on Github actions, we started seeing failures on Ubuntu for JDK8 due to GC overhead limits. This commit changes the command to only run CL2 benchmarks.
jonessha
approved these changes
Oct 23, 2023
baldawar
reviewed
Oct 24, 2023
| @@ -588,12 +646,24 @@ public void CL2Benchmark() throws Exception { | |||
|
|
|||
| bm = new Benchmarker(); | |||
|
|
|||
| bm.addRules(PREFIX_EQUALS_IGNORE_CASE_RULES, PREFIX_EQUALS_IGNORE_CASE_MATCHES); | |||
| bm.run(citylots2); | |||
| System.out.println("PREFIX_EQUALS_IGNORE_CASE_RULES events/sec: " + String.format("%.1f", bm.getEPS())); | |||
There was a problem hiding this comment.
update this section https://github.com/aws/event-ruler/blob/main/README.md#performance ?
| @@ -45,10 +45,18 @@ public static ValuePatterns prefixMatch(final String prefix) { | |||
| return new ValuePatterns(MatchType.PREFIX, prefix); | |||
| } | |||
|
|
|||
| public static ValuePatterns prefixEqualsIgnoreCaseMatch(final String prefix) { | |||
There was a problem hiding this comment.
this part of the doc needs an update https://github.com/aws/event-ruler/blob/main/README.md#the-patterns-api
| @@ -29,3 +29,5 @@ jobs: | |||
| cache: 'maven' | |||
| - name: Verify with Maven | |||
| run: mvn --batch-mode --errors --update-snapshots verify | |||
| - name: Run benchmarks | |||
There was a problem hiding this comment.
you can also update the comment within this template, so folks know how to update fetch the benchmark results (for now just pasting JDK 8 results is fine)
https://github.com/aws/event-ruler/blob/main/.github/PULL_REQUEST_TEMPLATE.md
added 2 commits
October 24, 2023 10:57
* Updated "Performance" section on README with benchmarks results * Updated "THe Patterns API" section on README with the new match types * Updated PR template with instructions on where to get the benchmarks
jonessha
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #108
Description of changes:
Benchmark / Performance (for source code changes):
From my mac laptop (2.6 GHz 6-Core Intel Core i7 / 16 GB 2667 MHz DDR4):
From the Github benchmark:
Java 8:
Java 11:
Java 17:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.