Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing GenericMachine/Machine Builder visibility so it is usable from outside packages #133

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fixing GenericMachine/Machine Builder visibility so it is usable from outside packages #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/software/amazon/event/ruler/GenericMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ public static Builder builder() {
return new Builder();
}

protected static class Builder<T extends GenericMachine> {
public static class Builder<T extends GenericMachine> {

/**
* Normally, NameStates are re-used for a given key subsequence and pattern if this key subsequence and pattern have
Expand All @@ -719,6 +719,8 @@ protected static class Builder<T extends GenericMachine> {
*/
private boolean additionalNameStateReuse = false;

Builder() {}

public Builder<T> withAdditionalNameStateReuse(boolean additionalNameStateReuse) {
this.additionalNameStateReuse = additionalNameStateReuse;
return this;
Expand Down
5 changes: 4 additions & 1 deletion src/main/software/amazon/event/ruler/Machine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ public static Builder builder() {
return new Builder();
}

protected static class Builder extends GenericMachine.Builder<Machine> {
public static class Builder extends GenericMachine.Builder<Machine> {

private Builder() {}

@Override
public Machine build() {
return new Machine(buildConfig());
Expand Down