Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some additional performance improvements #39

Merged
merged 7 commits into from
Sep 13, 2022
Merged

some additional performance improvements #39

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b080f1
speed up hex digitSequence creation
rudygt Sep 10, 2022
35f3ef4
avoid Stream.of().collect(Collectors.toSet()) to create sets
rudygt Sep 10, 2022
efff79a
get away from stepQueue make ACFinder recursive instead
rudygt Sep 10, 2022
5c5a35b
use a consistent style to create a set from a list
rudygt Sep 12, 2022
73311cc
add benchmark with deep nested events, bump version minor
rudygt Sep 12, 2022
9d34ea8
go back to != null instead of Objects.nonNull
rudygt Sep 12, 2022
ab3cb90
reduce magic constant usage on hex digit sequence generation
rudygt Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/software/amazon/event/ruler/Range.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
* implementation, the number of digits in the top and bottom of the range is the same.
*/
public class Range extends Patterns {

/**
* Bottom and top of the range. openBottom true means we're looking for > bottom, false means >=
* Similarly, openTop true means we're looking for < top, false means <= top.
Expand All @@ -21,6 +20,8 @@ public class Range extends Patterns {

final boolean isCIDR;

private static final int HEX_DIGIT_A_DECIMAL_VALUE = 10;

private Range(final double bottom, final boolean openBottom, final double top, final boolean openTop) {
super(MatchType.NUMERIC_RANGE);
if (bottom >= top) {
Expand Down Expand Up @@ -108,11 +109,11 @@ static byte[] digitSequence(byte first, byte last, boolean includeFirst, boolean

private static int getHexByteIndex(byte value) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonessha what do you think? I feel like using the chars helps with the clarity , and then only one obscure constant is needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you!

// ['0'-'9'] maps to [0-9] indexes
if (value >= 48 && value <= 57) {
return value - 48;
if (value >= '0' && value <= '9') {
return value - '0';
}
// ['A'-'F'] maps to [10-15] indexes
return (value - 65) + 10;
return (value - 'A') + HEX_DIGIT_A_DECIMAL_VALUE;
}

@Override
Expand Down