Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Ruler is internally a state-machine, so calculating its memory footprint requires checking 1/ all possible states, 2/ the path between various states, and 3/ any final stopping nodes.
As calculating exact memory is not possible without using profiling or other memory monitoring techniques, we are isntead counting each unique object as weight 1. We then calculate all possible states by traversing from the starting state-machine.
Internally this is implemented through build a set of object refs while traversing the entire the state-machine. This is ineffecient but allows us to review if "traversing the state machine" is the best technique. hashcodes also help block any looping situations.
Benchmark / Performance (for source code changes):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.