Node: added persist command. #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node/src/BaseClient.ts
Outdated
| * See https://redis.io/commands/persist/ for more details. | ||
| * | ||
| * @param key - The key to remove the existing timeout on. | ||
| * @returns 0 if `key` does not exist or does not have an associated timeout. 1 if the timeout has been removed. |
There was a problem hiding this comment.
this should be treated as a boolean, not an integer
adanWattad
force-pushed
the
node/persist
branch
2 times, most recently
from
98c0951
to
feb3f2a
Compare
shachlanAmazon
approved these changes
Mar 7, 2024
node/src/Transaction.ts
Outdated
| * | ||
| * @param key - The key to remove the existing timeout on. | ||
| * | ||
| * Command Response - false if `key` does not exist or does not have an associated timeout. true if the timeout has been removed. |
There was a problem hiding this comment.
"false if...", "true if ..."
same below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.