Node: Add support for XADD, XTRIM commands. #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shachlanAmazon
requested review from
ikolomi,
barshaul,
shohamazon and
adanWattad
|
@barshaul https://github.com/aws/glide-for-redis/actions/runs/8130292125/job/22218346793?pr=1057 same happened here |
nihohit
force-pushed
the
stream-add
branch
2 times, most recently
from
72471bb
to
c7fff8e
Compare
Yury-Fridlyand
approved these changes
Mar 6, 2024
barshaul
reviewed
Mar 10, 2024
| */ | ||
| public xadd( | ||
| key: string, | ||
| values: [string, string][], |
There was a problem hiding this comment.
why not using Record? it doesn't keep order?
There was a problem hiding this comment.
In javascript it keeps the order of insertions, but not in C#, python or others.
barshaul
approved these changes
Mar 10, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Co-authored-by: nihohit <nihohit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.