Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing doc and tests for multi-key commands #1391

Merged
merged 17 commits into from
May 17, 2024
Merged

Add missing doc and tests for multi-key commands #1391

merged 17 commits into from
May 17, 2024

Commits on May 7, 2024

  1. Add missing doc and tests for multi-key commands (#226) 

    * Add missing doc and tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Rework docs and tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* I HATE YOU SPOTLESS

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Experiment

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Experiment

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Experiment

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Experiment

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Experiment

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Experiment

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Experiment

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Experiment

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Linter

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Address PR comments.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a5e5519 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad… 

    …d_crossslot

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4ab284f View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Address PR comments. 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2be8d41 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad… 

    …d_crossslot

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3f91912 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
    @Yury-Fridlyand @aaron-congo
    Yury-Fridlyand and aaron-congo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    72f7960 View commit details
    Browse the repository at this point in the history

  4. Update and fix doc and tests. 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7afa3e0 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
    @Yury-Fridlyand @aaron-congo
    Yury-Fridlyand and aaron-congo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f4b3b2f View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. I HATE YOU SPOTLESS 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 11, 2024
    Configuration menu
    Copy the full SHA
    60ab21c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad… 

    …d_crossslot

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5aaaf6c View commit details
    Browse the repository at this point in the history

  2. Update node IT. 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 13, 2024
    Configuration menu
    Copy the full SHA
    755e114 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad… 

    …d_crossslot

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 13, 2024
    Configuration menu
    Copy the full SHA
    21a8e72 View commit details
    Browse the repository at this point in the history

  4. Update tests. 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 13, 2024
    Configuration menu
    Copy the full SHA
    eb99cfe View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Add version check. 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7d11ce6 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Apply suggestions from code review 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
    @Yury-Fridlyand @shohamazon
    Yury-Fridlyand and shohamazon committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8616ea4 View commit details
    Browse the repository at this point in the history

  2. I HATE YOU SPOTLESS 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 16, 2024
    Configuration menu
    Copy the full SHA
    87f000a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad… 

    …d_crossslot

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 16, 2024
    Configuration menu
    Copy the full SHA
    57b28cb View commit details
    Browse the repository at this point in the history

  4. Update python IT. 

    Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
    @Yury-Fridlyand
    Yury-Fridlyand committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0c917d5 View commit details
    Browse the repository at this point in the history