Java: Add BITOP command
#1458
Merged
Java: Add BITOP command
#1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
force-pushed
the
java/integ_guiang_bitop
branch
from
a96dd87
to
4895885
Compare
Yury-Fridlyand
approved these changes
May 24, 2024
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/bitmap/BitwiseOperation.java
Outdated
Show resolved
Hide resolved
jonathanl-bq
approved these changes
May 24, 2024
acarbonetto
reviewed
May 24, 2024
| * <pre>{@code | ||
| * client.set("key1", "A"); // "A" has binary value 01000001 | ||
| * client.set("key2", "B"); // "B" has binary value 01000010 | ||
| * Long payload = client.bitop(BitwiseOperation.AND, "destination", new String[] {key1, key2}).get(); |
There was a problem hiding this comment.
Suggested change
| * Long payload = client.bitop(BitwiseOperation.AND, "destination", new String[] {key1, key2}).get(); | |
| * Long payload = client.bitop(AND, "destination", new String[] {key1, key2}).get(); |
There was a problem hiding this comment.
Don't we want to specify the enum in the example?
There was a problem hiding this comment.
Not necessary. It's defined in the function and should be easy peasy to look up.
Yury-Fridlyand
approved these changes
May 24, 2024
acarbonetto
approved these changes
May 24, 2024
cyip10
pushed a commit
to Bit-Quill/glide-for-redis
that referenced
this pull request
Jun 24, 2024
* Java: Add `BITOP` command (#303) * Incomplete implementation * Needs more tests and javadocs * Fixed errors from rebasing * Added tests and javadocs * Fixed incorrect comment * Added tests * Fixed tests * Spotless * Added to module-info * Addressed PR comments * Added TODO:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Implements
BITOPcommand in the java client.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.