Node: Add ZUNIONSTORE command #1550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarovadya
force-pushed
the
zunionstore-node-command
branch
from
0d178ee
to
42fd636
Compare
adarovadya
force-pushed
the
zunionstore-node-command
branch
from
42fd636
to
e13fb1c
Compare
avifenesh
approved these changes
Jun 16, 2024
| * @param destination - The key of the destination sorted set. | ||
| * @param keys - The keys of the sorted sets with possible formats: | ||
| * string[] - for keys only. | ||
| * KeyWeight[] - for weighted keys with score multipliers. |
There was a problem hiding this comment.
Does weighted is clear to the user? I don't know what its mean so i would like to have an explantation in the docs, but if it's normally known to the user it is not necessary.
There was a problem hiding this comment.
On Java, we linked to the documentation for WeightedKeys object. Is it easy to jump to KeyWeight object on PyCharm?
| * await client.zadd("key1", {"member1": 10.5, "member2": 8.2}) | ||
| * await client.zadd("key2", {"member1": 9.5}) | ||
| * await client.zunionStore("my_sorted_set", ["key1", "key2"]) // Output: 2 - Indicates that the sorted set "my_sorted_set" contains two elements. | ||
| * await client.zrangeWithScores("my_sorted_set", RangeByIndex(0, -1)) // Output: {'member1': 20, 'member2': 8.2} - "member1" is now stored in "my_sorted_set" with score of 20 and "member2" with score of 8.2. |
There was a problem hiding this comment.
Can you add an example of using weighted?
| * await client.zrangeWithScores("my_sorted_set", RangeByIndex(0, -1)) // Output: {'member1': 10.5, 'member2': 8.2} - "member1" is now stored in "my_sorted_set" with score of 10.5 and "member2" with score of 8.2. | ||
| * ``` | ||
| */ | ||
| public zunionStore( |
There was a problem hiding this comment.
This should be in lowercase
Suggested change
| public zunionStore( | |
| public zunionstore( |
Please update examples too
There was a problem hiding this comment.
we're not too consistent with the *store naming
There was a problem hiding this comment.
It is a single word command name, so in user API we do the same.
In internal API it is in camel case
| * @param aggregationType - Specifies the aggregation strategy to apply when combining the scores of elements. See `AggregationType`. | ||
| * Command Response - The number of elements in the resulting sorted set stored at `destination`. | ||
| */ | ||
| public zunionStore( |
There was a problem hiding this comment.
Suggested change
| public zunionStore( | |
| public zunionstore( |
acarbonetto
approved these changes
Jun 18, 2024
| * await client.zrangeWithScores("my_sorted_set", RangeByIndex(0, -1)) // Output: {'member1': 10.5, 'member2': 8.2} - "member1" is now stored in "my_sorted_set" with score of 10.5 and "member2" with score of 8.2. | ||
| * ``` | ||
| */ | ||
| public zunionStore( |
There was a problem hiding this comment.
we're not too consistent with the *store naming
acarbonetto
reviewed
Aug 14, 2024
| * | ||
| * When in cluster mode, `destination` and all keys in `keys` must map to the same hash slot. | ||
| * | ||
| * See https://valkey.io/commands/zunionstore/ for more details. |
There was a problem hiding this comment.
Suggested change
| * See https://valkey.io/commands/zunionstore/ for more details. | |
| * @see {@link https://valkey.io/commands/zunionstore/|valkey.io} for details. |
| * When in cluster mode, `destination` and all keys in `keys` must map to the same hash slot. | ||
| * | ||
| * See https://valkey.io/commands/zunionstore/ for more details. | ||
|
|
| * If `destination` already exists, it is overwritten. Otherwise, a new sorted set will be created. | ||
| * To get the result directly, see `zunion_withscores`. | ||
| * | ||
| * See https://valkey.io/commands/zunionstore/ for more details. |
There was a problem hiding this comment.
Suggested change
| * See https://valkey.io/commands/zunionstore/ for more details. | |
| * @see {@link https://valkey.io/commands/zunionstore/|valkey.io} for details. |
| * To get the result directly, see `zunion_withscores`. | ||
| * | ||
| * See https://valkey.io/commands/zunionstore/ for more details. | ||
|
|
Merged
|
Closing as #2145 took its place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.