Added Script API in python. #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adanWattad
changed the title
barshaul
reviewed
Jan 28, 2024
python/python/glide/redis_client.py
Outdated
| @@ -228,6 +228,30 @@ async def execute_transaction( | |||
| await response_future | |||
| return response_future.result() | |||
|
|
|||
| async def execute_script( | |||
There was a problem hiding this comment.
execute_script => _execute_script
to communicate a private function in python
There was a problem hiding this comment.
please also fix execute_transaction => _execute_transaction
barshaul
reviewed
Jan 28, 2024
| request.script_invocation.args[:] = args if args is not None else [] | ||
| request.script_invocation.keys[:] = keys if keys is not None else [] | ||
| set_protobuf_route(request, route) | ||
| # Create a response future for this request and add it to the available |
There was a problem hiding this comment.
since the lines from here to the end of the function are repeating both in execute_command and execute_pipeline, lets move it to a separate function:
async def _write_request_await_response(self, request: RedisRequest):
# Create a response future for this request and add it to the available
# futures map
response_future = self._get_future(request.callback_idx)
self._create_write_task(request)
await response_future
return response_future.result()
adanWattad
force-pushed
the
pythonScripts
branch
from
3d4ecfc
to
65c96d1
Compare
adanWattad
force-pushed
the
pythonScripts
branch
from
65c96d1
to
dac826c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.