Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: adds SISMEMBER command #972

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

shohamazon
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon requested a review from a team as a code owner February 15, 2024 15:33
@shohamazon shohamazon force-pushed the python/sismember branch 2 times, most recently from 31a61f6 to 7b647dd Compare February 15, 2024 15:48
member (str): The member to check for existence in the set.

Returns:
int: 1 if the member exists in the set, 0 otherwise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as in the HSETNX PR - can we parse this command response in rust and return a boolean instead of an int?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will


Returns:
int: 1 if the member exists in the set, 0 otherwise.
If `key` is not a set, it is treated an an empty set and the command returns 0.
Copy link
Contributor

@barshaul barshaul Feb 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If key is not a set, it is treated an an empty => If key is not a set, it is treated as an empty s

@shohamazon shohamazon merged commit 3809a28 into aws:main Feb 29, 2024
40 checks passed
@shohamazon shohamazon deleted the python/sismember branch February 29, 2024 13:23
cyip10 pushed a commit to Bit-Quill/glide-for-redis that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants