136 iam credentials not used when calling neptune #140
Conversation
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
=====================================
Coverage 9.09% 9.09%
=====================================
Files 444 444
Lines 29697 29697
Branches 208 208
=====================================
Hits 2701 2701
Misses 26990 26990
Partials 6 6 |
packages/.DS_Store
Outdated
There was a problem hiding this comment.
Please remove all .DS_Store files from the PR.
There was a problem hiding this comment.
thanks, this has now been done.
| fetch(url, { headers: req.headers, }) | ||
| .then(async res => { | ||
| console.log("url: ", urlString); | ||
| console.log; |
| service: "neptune-db", | ||
| region: headers["aws-neptune-region"], | ||
| }).then((data) => { | ||
| headers = data; |
There was a problem hiding this comment.
If I understand correctly, we are replacing the headers passed to the function with the IAM headers here.
Q. Is there a risk that if any headers were passed in the request, they would be removed and if so, should we append the IAM headers to headers instead of replacing?
…rough on every request, even when IAM is turned on.
…rough on every request, even when IAM is turned on.
| next(error); | ||
| console.log(error); | ||
| // send the json response in the next call | ||
| res.send(error); |
There was a problem hiding this comment.
We have different code in the catch block of RDF summary call compared to PG summary call:
PG one has next(error); whereas this RDF one has res.send(error);
Not sure if they function similarly thus calling out to double-check.
There was a problem hiding this comment.
refactored to have the same behaviour
| console.error("No IAM credentials found in provider chain", e); | ||
| } | ||
| }; | ||
| const e = require("express"); |
There was a problem hiding this comment.
Looks like this might be unused, recommend removing it if not required.
packages/.DS_Store
Outdated
There was a problem hiding this comment.
Consider deleting the 2 .DS_Store files explicitely since it looks like the updated .gitignore is not applying on already committed code.
michaelnchin
deleted the
136-iam-credentials-not-used-when-calling-neptune
branch
Issue #136
Description of changes:
Refactored the Proxy server to generate the IAM auth header correctly, and only when IAM is active.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.