Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create connection cleanup #445

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 19, 2024

Description

  • Add vertical padding to list item content
  • Allow flex items to take full width in connection detail pane
  • Move existing config deconstruction logic in to CreateConnection modal code
  • Rename form properties to match config connection property names
  • Remove unnecessary mapping after rename
  • Add separate boolean for fetch timeout enabled
    • This fixes an issue where if the user deletes all text in the input, the check box automatically unchecks and the input disappears

Validation

  • Verified old config values carry over properly
  • Verified new and old connections are created/updated properly

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 19, 2024 18:00
@kmcginnes kmcginnes marked this pull request as ready for review June 19, 2024 18:00
@kmcginnes kmcginnes merged commit 6ef3185 into aws:main Jun 19, 2024
1 check passed
@kmcginnes kmcginnes deleted the create-connection-cleanup branch June 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Long URLs are have no vertical padding in connection list
2 participants