Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expand limit to connection #447

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Add expand limit to connection #447

merged 7 commits into from
Jun 20, 2024

Conversation

kmcginnes
Copy link
Collaborator

Description

Adds a global node expansion limit to the connection.

  • Default is off for new and existing connections
  • Updated documentation for new environment value GRAPH_EXP_NODE_EXPANSION_LIMIT
  • Ensure fetch neighbors and neighbor counts queries respect the limit
  • Updated tests

Validation

  • Tested limits respected across query engines
  • Tested queries are refetched when limit changes
  • Tested new and existing connections function as expected

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 20, 2024 00:24
@kmcginnes kmcginnes marked this pull request as ready for review June 20, 2024 00:24
@kmcginnes kmcginnes merged commit abc48b4 into aws:main Jun 20, 2024
1 check passed
@kmcginnes kmcginnes deleted the expand-limit branch June 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add expansion limit option per connection
2 participants