Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparql template cleanup #448

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Sparql template cleanup #448

merged 4 commits into from
Jun 20, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 20, 2024 •
edited
Loading

Description

Minor cleanup that doesn't change any critical logic.

  • Adds dedent dependency which will remove indentation from strings
  • Use dedent on SPARQL queries
  • Convert closure expressions to functions

Validation

  • Did a brief smoke test

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 20, 2024 15:16
@kmcginnes kmcginnes marked this pull request as ready for review June 20, 2024 15:17
@vkagamlyk
Copy link
Contributor

good to add dedent license to https://github.com/aws/graph-explorer/blob/main/THIRD_PARTY_LICENSES.txt

@kmcginnes kmcginnes merged commit 5811777 into aws:main Jun 20, 2024
1 check passed
@kmcginnes kmcginnes deleted the sparql-template-cleanup branch June 20, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkagamlyk vkagamlyk vkagamlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmcginnes @vkagamlyk