Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OC group-by-label, add OC group-by-depth #241

Merged
merged 1 commit into from Jan 10, 2022
Merged

Conversation

michaelnchin
Copy link
Member

Issue #, if available: #147

Description of changes:

  • Modified --group-by on label for openCypher to bring it line with SPARQL and Gremlin (I.e. switched syntax from {"airport":{"groupby":"code"}} to {"airport":"code"})
  • Added grouping by node depth for openCypher queries. To color nodes bases on depth, the query must return a set of paths in list format, and users must specify TRAVERSAL_DEPTH as the grouping property.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krlawrence
Copy link
Contributor

Can we also add the group by depth for Gremlin queries?

@michaelnchin
Copy link
Member Author

Yes, this is being worked on for Gremlin, and will be added in a later update

Copy link
Contributor

@bechbd bechbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I would also like to see us add this to Gremlin in order to maintain parity between the functionality

Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important we try and keep the functionality between the OC and Gremlin visuals in sync. Are you planning to add these same changes to Gremlin? It is equally needed there as well.

@michaelnchin
Copy link
Member Author

Implementing for Gremlin in a separate PR.

@michaelnchin michaelnchin merged commit 8914dd8 into main Jan 10, 2022
@michaelnchin michaelnchin deleted the oc-group-by-depth branch January 10, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants