fix: files are not excluded when using user-provided tsconfig (and various other fixes and improvements) #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
changed the title
mrgrain
force-pushed
the
mrgrain/fix/custom-tsconfig-fixes
branch
2 times, most recently
from
9401965
to
10afc1f
Compare
mrgrain
changed the title
mrgrain
force-pushed
the
mrgrain/fix/custom-tsconfig-fixes
branch
from
10afc1f
to
809e1ed
Compare
rix0rrr
approved these changes
May 15, 2024
aws-cdk-automation
pushed a commit
that referenced
this pull request
May 16, 2024
…rious other fixes and improvements) (#969) When using a user-provided tsconfig, the `exclude` and `include` options were incorrectly dropped and instead all `*.ts` files were always included in the build. This change also improves on the compile test which previously actually didn't compile anything. Also added a bunch of additional configurable options to make many more common tsconfigs pass the the strict validation. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 2a19bf8)
aws-cdk-automation
pushed a commit
that referenced
this pull request
May 16, 2024
…rious other fixes and improvements) (#969) When using a user-provided tsconfig, the `exclude` and `include` options were incorrectly dropped and instead all `*.ts` files were always included in the build. This change also improves on the compile test which previously actually didn't compile anything. Also added a bunch of additional configurable options to make many more common tsconfigs pass the the strict validation. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 2a19bf8)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
aws-cdk-automation
pushed a commit
that referenced
this pull request
May 16, 2024
…rious other fixes and improvements) (#969) When using a user-provided tsconfig, the `exclude` and `include` options were incorrectly dropped and instead all `*.ts` files were always included in the build. This change also improves on the compile test which previously actually didn't compile anything. Also added a bunch of additional configurable options to make many more common tsconfigs pass the the strict validation. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 2a19bf8)
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2024
…rious other fixes and improvements) (backport #969) (#981) # Backport This will backport the following commits from `main` to `maintenance/v5.2`: - [fix: files are not excluded when using user-provided tsconfig (and various other fixes and improvements) (#969)](#969) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2024
…rious other fixes and improvements) (backport #969) (#982) # Backport This will backport the following commits from `main` to `maintenance/v5.3`: - [fix: files are not excluded when using user-provided tsconfig (and various other fixes and improvements) (#969)](#969) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a user-provided tsconfig, the
excludeandincludeoptions were incorrectly dropped and instead all*.tsfiles were always included in the build.This change also improves on the compile test which previously actually didn't compile anything.
Also added a bunch of additional configurable options to make many more common tsconfigs pass the the strict validation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.