fix: processing example is failing when example contains jsdoc annotated export #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Momo Kornher <kornherm@amazon.co.uk>
mrgrain
changed the title
otaviomacedo
approved these changes
Apr 23, 2024
aws-cdk-automation
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (#1170) Fixes #1161 The code to process statements was making some incorrect assumptions about how the AST looks like. This fix is making it more resilient to unexpected AST structures. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: Momo Kornher <kornherm@amazon.co.uk> (cherry picked from commit b41e905)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (#1170) Fixes #1161 The code to process statements was making some incorrect assumptions about how the AST looks like. This fix is making it more resilient to unexpected AST structures. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: Momo Kornher <kornherm@amazon.co.uk> (cherry picked from commit b41e905)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (#1170) Fixes #1161 The code to process statements was making some incorrect assumptions about how the AST looks like. This fix is making it more resilient to unexpected AST structures. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: Momo Kornher <kornherm@amazon.co.uk> (cherry picked from commit b41e905)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (#1170) Fixes #1161 The code to process statements was making some incorrect assumptions about how the AST looks like. This fix is making it more resilient to unexpected AST structures. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: Momo Kornher <kornherm@amazon.co.uk> (cherry picked from commit b41e905)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (#1170) Fixes #1161 The code to process statements was making some incorrect assumptions about how the AST looks like. This fix is making it more resilient to unexpected AST structures. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: Momo Kornher <kornherm@amazon.co.uk> (cherry picked from commit b41e905)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (#1170) Fixes #1161 The code to process statements was making some incorrect assumptions about how the AST looks like. This fix is making it more resilient to unexpected AST structures. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: Momo Kornher <kornherm@amazon.co.uk> (cherry picked from commit b41e905)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (#1170) Fixes #1161 The code to process statements was making some incorrect assumptions about how the AST looks like. This fix is making it more resilient to unexpected AST structures. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: Momo Kornher <kornherm@amazon.co.uk> (cherry picked from commit b41e905)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
aws-cdk-automation
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (#1170) Fixes #1161 The code to process statements was making some incorrect assumptions about how the AST looks like. This fix is making it more resilient to unexpected AST structures. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: Momo Kornher <kornherm@amazon.co.uk> (cherry picked from commit b41e905)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (backport #1170) (#1216) # Backport This will backport the following commits from `main` to `maintenance/v5.2`: - [fix: processing example is failing when example contains jsdoc annotated export (#1170)](#1170) <!--- Backport version: 9.3.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (backport #1170) (#1217) # Backport This will backport the following commits from `main` to `maintenance/v5.1`: - [fix: processing example is failing when example contains jsdoc annotated export (#1170)](#1170) <!--- Backport version: 9.3.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…ted export (backport #1170) (#1218) # Backport This will backport the following commits from `main` to `maintenance/v5.3`: - [fix: processing example is failing when example contains jsdoc annotated export (#1170)](#1170) <!--- Backport version: 9.3.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1161
The code to process statements was making some incorrect assumptions about how the AST looks like.
This fix is making it more resilient to unexpected AST structures.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.