Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error TS2339: Property 'VISUALIZE' does not exist on type 'typeof TargetLanguage' #1293

Merged
merged 2 commits into from
May 6, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 3, 2024

We are using the @internal directive to instruct typescript compiler to drop some statements during compilation.
This may cause the compiler to emit invalid declarations if we are not careful.
To guarantee that our declarations are valid, we do an additional run of tsc on the output.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit cb8d1d2 May 6, 2024
16 of 19 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/invalid-ts-d branch May 6, 2024 08:42
aws-cdk-automation pushed a commit that referenced this pull request May 6, 2024
…f TargetLanguage' (#1293)

We are using the `@internal` directive to instruct typescript compiler
to drop some statements during compilation.
This may cause the compiler to emit invalid declarations if we are not
careful.
To guarantee that our declarations are valid, we do an additional run of
tsc on the output.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

(cherry picked from commit cb8d1d2)
aws-cdk-automation pushed a commit that referenced this pull request May 6, 2024
…f TargetLanguage' (#1293)

We are using the `@internal` directive to instruct typescript compiler
to drop some statements during compilation.
This may cause the compiler to emit invalid declarations if we are not
careful.
To guarantee that our declarations are valid, we do an additional run of
tsc on the output.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

(cherry picked from commit cb8d1d2)
@aws-cdk-automation
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
maintenance/v5.2
maintenance/v5.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
…f TargetLanguage' (backport #1293) (#1310)

# Backport

This will backport the following commits from `main` to
`maintenance/v5.3`:
- [fix: error TS2339: Property 'VISUALIZE' does not exist on
type 'typeof TargetLanguage'
(#1293)](#1293)

<!--- Backport version: 9.3.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
…f TargetLanguage' (backport #1293) (#1309)

# Backport

This will backport the following commits from `main` to
`maintenance/v5.2`:
- [fix: error TS2339: Property &#x27;VISUALIZE&#x27; does not exist on
type &#x27;typeof TargetLanguage&#x27;
(#1293)](#1293)

<!--- Backport version: 9.3.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants