-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error TS2339: Property 'VISUALIZE' does not exist on type 'typeof TargetLanguage' #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
May 6, 2024
aws-cdk-automation
pushed a commit
that referenced
this pull request
May 6, 2024
…f TargetLanguage' (#1293) We are using the `@internal` directive to instruct typescript compiler to drop some statements during compilation. This may cause the compiler to emit invalid declarations if we are not careful. To guarantee that our declarations are valid, we do an additional run of tsc on the output. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit cb8d1d2)
aws-cdk-automation
pushed a commit
that referenced
this pull request
May 6, 2024
…f TargetLanguage' (#1293) We are using the `@internal` directive to instruct typescript compiler to drop some statements during compilation. This may cause the compiler to emit invalid declarations if we are not careful. To guarantee that our declarations are valid, we do an additional run of tsc on the output. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit cb8d1d2)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
…f TargetLanguage' (backport #1293) (#1310) # Backport This will backport the following commits from `main` to `maintenance/v5.3`: - [fix: error TS2339: Property 'VISUALIZE' does not exist on type 'typeof TargetLanguage' (#1293)](#1293) <!--- Backport version: 9.3.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
…f TargetLanguage' (backport #1293) (#1309) # Backport This will backport the following commits from `main` to `maintenance/v5.2`: - [fix: error TS2339: Property 'VISUALIZE' does not exist on type 'typeof TargetLanguage' (#1293)](#1293) <!--- Backport version: 9.3.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the
@internal
directive to instruct typescript compiler to drop some statements during compilation.This may cause the compiler to emit invalid declarations if we are not careful.
To guarantee that our declarations are valid, we do an additional run of tsc on the output.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.