chore: restore ability to release maintenance version lines #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
May 20, 2024
aws-cdk-automation
deleted the
mrgrain/chore/ci/config-backport-prevents-old-releases
branch
aws-cdk-automation
pushed a commit
that referenced
this pull request
May 20, 2024
Same as aws/jsii-compiler#998, but for jsii-rosetta This repo was using an automatic backport feature for repository config. As part of daily upgrades, the projen config would be checked out from `main` and applied to maintenance branches. However because we also defined the current version in this config, this inadvertently changed the current version for maintenance branches as well! In practice that meant that the release tagging workflow tagged the wrong release lines. This fix does two things: - Disable the automatic backport of configuration in favor of the new, explicit label based backport feature (see it in action on this PR!) - Add an explicit release line option to the tagging workflow, that will be compared against the detected TypeScript version and fail if they don't match. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 08daef4)
aws-cdk-automation
pushed a commit
that referenced
this pull request
May 20, 2024
Same as aws/jsii-compiler#998, but for jsii-rosetta This repo was using an automatic backport feature for repository config. As part of daily upgrades, the projen config would be checked out from `main` and applied to maintenance branches. However because we also defined the current version in this config, this inadvertently changed the current version for maintenance branches as well! In practice that meant that the release tagging workflow tagged the wrong release lines. This fix does two things: - Disable the automatic backport of configuration in favor of the new, explicit label based backport feature (see it in action on this PR!) - Add an explicit release line option to the tagging workflow, that will be compared against the detected TypeScript version and fail if they don't match. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 08daef4)
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
aws-cdk-automation
pushed a commit
that referenced
this pull request
May 20, 2024
Same as aws/jsii-compiler#998, but for jsii-rosetta This repo was using an automatic backport feature for repository config. As part of daily upgrades, the projen config would be checked out from `main` and applied to maintenance branches. However because we also defined the current version in this config, this inadvertently changed the current version for maintenance branches as well! In practice that meant that the release tagging workflow tagged the wrong release lines. This fix does two things: - Disable the automatic backport of configuration in favor of the new, explicit label based backport feature (see it in action on this PR!) - Add an explicit release line option to the tagging workflow, that will be compared against the detected TypeScript version and fail if they don't match. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 08daef4)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
…1386) (#1387) # Backport This will backport the following commits from `main` to `maintenance/v5.2`: - [chore: restore ability to release maintenance version lines (#1386)](#1386) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) --------- Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
…1386) (#1388) # Backport This will backport the following commits from `main` to `maintenance/v5.3`: - [chore: restore ability to release maintenance version lines (#1386)](#1386) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) --------- Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as aws/jsii-compiler#998, but for jsii-rosetta
This repo was using an automatic backport feature for repository config. As part of daily upgrades, the projen config would be checked out from
mainand applied to maintenance branches. However because we also defined the current version in this config, this inadvertently changed the current version for maintenance branches as well! In practice that meant that the release tagging workflow tagged the wrong release lines.This fix does two things:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.