Skip to content

Commit 6164b6b

Browse files
RomainMullermergify[bot]
authored andcommitted
feat: configure engines with node >= 10.3.0 (#795)
* feat: configure `engines` with `node >= 10.0.0` As `node 8` is becoming EOL soon, we're upgrading the baseline `node` version requirement from `>= 8.10.0` to `>= 10.0.0`. At this point, the code generation is not affected, but this our first signal to consumers that they need to upgrade their runtimes and/or codebases. Additionally, normalized the order of fields in the `package.json` files to make it nicer for people to work in the mono-repo. Related to #794 * fix broken tests, bump minimal node to 10.3.0 * Update CONTRIBUTING.md
1 parent 7d5d104 commit 6164b6b

File tree

40 files changed

+547
-376
lines changed

40 files changed

+547
-376
lines changed

packages/codemaker/package.json

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,23 @@
22
"name": "codemaker",
33
"version": "0.17.0",
44
"description": "A tiny utility for generating source code",
5+
"license": "Apache-2.0",
6+
"author": {
7+
"name": "Amazon Web Services",
8+
"url": "https://aws.amazon.com"
9+
},
10+
"homepage": "https://github.com/aws/jsii",
11+
"bugs": {
12+
"url": "https://github.com/aws/jsii/issues"
13+
},
14+
"repository": {
15+
"type": "git",
16+
"url": "https://github.com/aws/jsii.git",
17+
"directory": "packages/codemaker"
18+
},
19+
"engines": {
20+
"node": ">= 10.3.0"
21+
},
522
"main": "lib/index.js",
623
"types": "lib/index.d.ts",
724
"scripts": {
@@ -11,6 +28,11 @@
1128
"test": "jest",
1229
"package": "rm -fr dist/js && mkdir -p dist/js && mv $(npm pack) dist/js"
1330
},
31+
"dependencies": {
32+
"camelcase": "^5.3.1",
33+
"decamelize": "^1.2.0",
34+
"fs-extra": "^8.1.0"
35+
},
1436
"devDependencies": {
1537
"@types/decamelize": "^1.2.0",
1638
"@types/fs-extra": "^8.0.0",
@@ -21,11 +43,6 @@
2143
"jest": "^24.9.0",
2244
"typescript": "~3.6.3"
2345
},
24-
"dependencies": {
25-
"camelcase": "^5.3.1",
26-
"decamelize": "^1.2.0",
27-
"fs-extra": "^8.1.0"
28-
},
2946
"jest": {
3047
"collectCoverage": true,
3148
"collectCoverageFrom": [
@@ -47,15 +64,5 @@
4764
"testMatch": [
4865
"**/?(*.)+(spec|test).js"
4966
]
50-
},
51-
"author": {
52-
"name": "Amazon Web Services",
53-
"url": "https://aws.amazon.com"
54-
},
55-
"license": "Apache-2.0",
56-
"repository": {
57-
"type": "git",
58-
"url": "https://github.com/aws/jsii.git",
59-
"directory": "packages/codemaker"
6067
}
6168
}
Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,25 @@
11
{
22
"name": "jsii-build-tools",
33
"version": "0.17.0",
4-
"description": "Internal repository-level tools",
54
"private": true,
5+
"description": "Internal repository-level tools",
6+
"license": "Apache-2.0",
7+
"author": {
8+
"name": "Amazon Web Services",
9+
"url": "https://aws.amazon.com"
10+
},
11+
"homepage": "https://github.com/aws/jsii",
12+
"bugs": {
13+
"url": "https://github.com/aws/jsii/issues"
14+
},
15+
"repository": {
16+
"type": "git",
17+
"url": "https://github.com/aws/jsii.git",
18+
"directory": "packages/jsii-build-tools"
19+
},
20+
"engines": {
21+
"node": ">= 10.3.0"
22+
},
623
"bin": {
724
"diff-test": "bin/diff-test",
825
"package-js": "bin/package-js",
@@ -13,14 +30,5 @@
1330
},
1431
"scripts": {
1532
"build": "chmod +x bin/*"
16-
},
17-
"author": {
18-
"name": "Amazon Web Services",
19-
"url": "https://aws.amazon.com"
20-
},
21-
"license": "Apache-2.0",
22-
"repository": {
23-
"type": "git",
24-
"url": "https://github.com/aws/jsii.git"
2533
}
2634
}
Lines changed: 27 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,36 @@
11
{
22
"name": "@scope/jsii-calc-base-of-base",
33
"version": "0.17.0",
4+
"private": true,
45
"description": "An example transitive dependency for jsii-calc.",
6+
"license": "Apache-2.0",
7+
"author": {
8+
"name": "Amazon Web Services",
9+
"url": "https://aws.amazon.com",
10+
"organization": true
11+
},
12+
"homepage": "https://github.com/aws/jsii",
13+
"bugs": {
14+
"url": "https://github.com/aws/jsii/issues"
15+
},
16+
"repository": {
17+
"type": "git",
18+
"url": "https://github.com/aws/jsii.git",
19+
"directory": "packages/jsii-calc-base-of-base"
20+
},
21+
"engines": {
22+
"node": ">= 10.3.0"
23+
},
524
"main": "lib/index.js",
625
"types": "lib/index.d.ts",
7-
"private": true,
26+
"scripts": {
27+
"build": "jsii",
28+
"test": "diff-test test/assembly.jsii .jsii"
29+
},
30+
"devDependencies": {
31+
"jsii": "^0.17.0",
32+
"jsii-build-tools": "file:../jsii-build-tools"
33+
},
834
"jsii": {
935
"outdir": "dist",
1036
"targets": {
@@ -26,23 +52,5 @@
2652
"sphinx": {}
2753
},
2854
"versionFormat": "short"
29-
},
30-
"scripts": {
31-
"build": "jsii",
32-
"test": "diff-test test/assembly.jsii .jsii"
33-
},
34-
"devDependencies": {
35-
"jsii": "^0.17.0",
36-
"jsii-build-tools": "file:../jsii-build-tools"
37-
},
38-
"author": {
39-
"name": "Amazon Web Services",
40-
"url": "https://aws.amazon.com",
41-
"organization": true
42-
},
43-
"license": "Apache-2.0",
44-
"repository": {
45-
"type": "git",
46-
"url": "https://github.com/aws/jsii.git"
4755
}
4856
}

packages/jsii-calc-base-of-base/test/assembly.jsii

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@
88
"url": "https://aws.amazon.com"
99
},
1010
"description": "An example transitive dependency for jsii-calc.",
11-
"homepage": "https://github.com/aws/jsii.git",
11+
"homepage": "https://github.com/aws/jsii",
1212
"jsiiVersion": "0.17.0",
1313
"license": "Apache-2.0",
1414
"name": "@scope/jsii-calc-base-of-base",
1515
"repository": {
16+
"directory": "packages/jsii-calc-base-of-base",
1617
"type": "git",
1718
"url": "https://github.com/aws/jsii.git"
1819
},
@@ -111,5 +112,5 @@
111112
}
112113
},
113114
"version": "0.17.0",
114-
"fingerprint": "DqwNq9h/I55u0SJmn4804sgX3QdJRlvZtK1bdBrZsdA="
115+
"fingerprint": "yqiCTEwufvpRvUJWXKok91vl3nOo7pVkbTPYM2LMs0A="
115116
}

packages/jsii-calc-base/package.json

Lines changed: 33 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,42 @@
11
{
22
"name": "@scope/jsii-calc-base",
33
"version": "0.17.0",
4+
"private": true,
45
"description": "An example direct dependency for jsii-calc.",
6+
"license": "Apache-2.0",
7+
"author": {
8+
"name": "Amazon Web Services",
9+
"url": "https://aws.amazon.com",
10+
"organization": true
11+
},
12+
"homepage": "https://github.com/aws/jsii",
13+
"bugs": {
14+
"url": "https://github.com/aws/jsii/issues"
15+
},
16+
"repository": {
17+
"type": "git",
18+
"url": "https://github.com/aws/jsii.git",
19+
"directory": "packages/jsii-calc-base"
20+
},
21+
"engines": {
22+
"node": ">= 10.3.0"
23+
},
524
"main": "lib/index.js",
625
"types": "lib/index.d.ts",
7-
"private": true,
26+
"scripts": {
27+
"build": "jsii",
28+
"test": "diff-test test/assembly.jsii .jsii"
29+
},
30+
"dependencies": {
31+
"@scope/jsii-calc-base-of-base": "file:../jsii-calc-base-of-base"
32+
},
33+
"peerDependencies": {
34+
"@scope/jsii-calc-base-of-base": "file:../jsii-calc-base-of-base"
35+
},
36+
"devDependencies": {
37+
"jsii": "^0.17.0",
38+
"jsii-build-tools": "file:../jsii-build-tools"
39+
},
840
"jsii": {
941
"outdir": "dist",
1042
"targets": {
@@ -26,29 +58,5 @@
2658
"sphinx": {}
2759
},
2860
"versionFormat": "short"
29-
},
30-
"scripts": {
31-
"build": "jsii",
32-
"test": "diff-test test/assembly.jsii .jsii"
33-
},
34-
"devDependencies": {
35-
"jsii": "^0.17.0",
36-
"jsii-build-tools": "file:../jsii-build-tools"
37-
},
38-
"dependencies": {
39-
"@scope/jsii-calc-base-of-base": "file:../jsii-calc-base-of-base"
40-
},
41-
"peerDependencies": {
42-
"@scope/jsii-calc-base-of-base": "file:../jsii-calc-base-of-base"
43-
},
44-
"author": {
45-
"name": "Amazon Web Services",
46-
"url": "https://aws.amazon.com",
47-
"organization": true
48-
},
49-
"license": "Apache-2.0",
50-
"repository": {
51-
"type": "git",
52-
"url": "https://github.com/aws/jsii.git"
5361
}
5462
}

packages/jsii-calc-base/test/assembly.jsii

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,12 @@
6060
}
6161
},
6262
"description": "An example direct dependency for jsii-calc.",
63-
"homepage": "https://github.com/aws/jsii.git",
63+
"homepage": "https://github.com/aws/jsii",
6464
"jsiiVersion": "0.17.0",
6565
"license": "Apache-2.0",
6666
"name": "@scope/jsii-calc-base",
6767
"repository": {
68+
"directory": "packages/jsii-calc-base",
6869
"type": "git",
6970
"url": "https://github.com/aws/jsii.git"
7071
},
@@ -176,5 +177,5 @@
176177
}
177178
},
178179
"version": "0.17.0",
179-
"fingerprint": "5fkhCkLN3NW/852/Ev17AgjuixpMt+Zq5QauaWnPt3s="
180+
"fingerprint": "DDUI6HStojy2shnkcuy/OPKGon00z+H3UmkaetCe9l4="
180181
}
Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,23 @@
11
{
22
"name": "jsii-calc-bundled",
33
"version": "0.17.0",
4-
"main": "index.js",
54
"private": true,
5+
"license": "Apache-2.0",
66
"author": {
77
"name": "Amazon Web Services",
88
"url": "https://aws.amazon.com"
99
},
10-
"license": "Apache-2.0",
10+
"homepage": "https://github.com/aws/jsii",
11+
"bugs": {
12+
"url": "https://github.com/aws/jsii/issues"
13+
},
1114
"repository": {
1215
"type": "git",
13-
"url": "https://github.com/aws/jsii.git"
14-
}
16+
"url": "https://github.com/aws/jsii.git",
17+
"directory": "packages/jsii-calc-bundled"
18+
},
19+
"engines": {
20+
"node": ">= 10.3.0"
21+
},
22+
"main": "index.js"
1523
}

packages/jsii-calc-lib/package.json

Lines changed: 34 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,44 @@
11
{
22
"name": "@scope/jsii-calc-lib",
33
"version": "0.17.0",
4+
"private": true,
45
"description": "A simple calcuator library built on JSII.",
5-
"stability": "deprecated",
66
"deprecated": "Really just deprecated for shows...",
7+
"stability": "deprecated",
8+
"license": "Apache-2.0",
9+
"author": {
10+
"name": "Amazon Web Services",
11+
"url": "https://aws.amazon.com",
12+
"organization": true
13+
},
14+
"homepage": "https://github.com/aws/jsii",
15+
"bugs": {
16+
"url": "https://github.com/aws/jsii/issues"
17+
},
18+
"repository": {
19+
"type": "git",
20+
"url": "https://github.com/aws/jsii.git",
21+
"directory": "packages/jsii-calc-lib"
22+
},
23+
"engines": {
24+
"node": ">= 10.3.0"
25+
},
726
"main": "lib/index.js",
827
"types": "lib/index.d.ts",
9-
"private": true,
28+
"scripts": {
29+
"build": "jsii",
30+
"test": "diff-test test/assembly.jsii .jsii"
31+
},
32+
"dependencies": {
33+
"@scope/jsii-calc-base": "file:../jsii-calc-base"
34+
},
35+
"peerDependencies": {
36+
"@scope/jsii-calc-base": "file:../jsii-calc-base"
37+
},
38+
"devDependencies": {
39+
"jsii": "^0.17.0",
40+
"jsii-build-tools": "file:../jsii-build-tools"
41+
},
1042
"jsii": {
1143
"outdir": "dist",
1244
"targets": {
@@ -30,29 +62,5 @@
3062
"sphinx": {}
3163
},
3264
"versionFormat": "short"
33-
},
34-
"scripts": {
35-
"build": "jsii",
36-
"test": "diff-test test/assembly.jsii .jsii"
37-
},
38-
"devDependencies": {
39-
"jsii": "^0.17.0",
40-
"jsii-build-tools": "file:../jsii-build-tools"
41-
},
42-
"dependencies": {
43-
"@scope/jsii-calc-base": "file:../jsii-calc-base"
44-
},
45-
"peerDependencies": {
46-
"@scope/jsii-calc-base": "file:../jsii-calc-base"
47-
},
48-
"author": {
49-
"name": "Amazon Web Services",
50-
"url": "https://aws.amazon.com",
51-
"organization": true
52-
},
53-
"license": "Apache-2.0",
54-
"repository": {
55-
"type": "git",
56-
"url": "https://github.com/aws/jsii.git"
5765
}
5866
}

0 commit comments

Comments
 (0)