Skip to content

Commit

Permalink
Rename BaseKernel/ProcessKernel to Provider to make it more distinct (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
dstufft committed Mar 14, 2019
1 parent 0275944 commit 7cc65a1
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions packages/jsii-python-runtime/src/jsii/_kernel/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

from jsii import _reference_map
from jsii._utils import Singleton
from jsii._kernel.providers import BaseKernel, ProcessKernel
from jsii._kernel.providers import BaseProvider, ProcessProvider
from jsii._kernel.types import JSClass, Referenceable
from jsii._kernel.types import (
EnumRef,
Expand Down Expand Up @@ -128,7 +128,7 @@ class Kernel(metaclass=Singleton):
# them at this layer to translate it to something more Pythonic, depending
# on what the provider layer looks like.

def __init__(self, provider_class: Type[BaseKernel] = ProcessKernel) -> None:
def __init__(self, provider_class: Type[BaseProvider] = ProcessProvider) -> None:
self.provider = provider_class()

# TODO: Do we want to return anything from this method? Is the return value useful
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from jsii._kernel.providers.base import BaseKernel
from jsii._kernel.providers.process import ProcessKernel
from jsii._kernel.providers.base import BaseProvider
from jsii._kernel.providers.process import ProcessProvider


__all__ = ["BaseKernel", "ProcessKernel"]
__all__ = ["BaseProvider", "ProcessProvider"]
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
)


class BaseKernel(metaclass=abc.ABCMeta):
class BaseProvider(metaclass=abc.ABCMeta):

# The API provided by this Kernel is not very pythonic, however it is done to map
# The API provided by this Provider is not very pythonic, however it is done to map
# this API as closely to the JSII runtime as possible. Higher level abstractions
# that layer ontop of the Kernel will provide a translation layer that make this
# that layer ontop of the Provider will provide a translation layer that make this
# much more Pythonic.

@abc.abstractmethod
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from jsii.__meta__ import __jsii_runtime_version__
from jsii._compat import importlib_resources
from jsii._utils import memoized_property
from jsii._kernel.providers.base import BaseKernel
from jsii._kernel.providers.base import BaseProvider
from jsii._kernel.types import (
ObjRef,
EnumRef,
Expand Down Expand Up @@ -302,7 +302,7 @@ def send(
raise JSIIError(resp.error) from JavaScriptError(resp.stack)


class ProcessKernel(BaseKernel):
class ProcessProvider(BaseProvider):
@memoized_property
def _process(self) -> _NodeProcess:
process = _NodeProcess()
Expand Down

0 comments on commit 7cc65a1

Please sign in to comment.