Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsii is printing some warning to the stderr about potential compatibility issues with Node 17 #3171

Closed
chenwany opened this issue Nov 15, 2021 · 1 comment · Fixed by #3841
Closed

jsii is printing some warning to the stderr about potential compatibility issues with Node 17 #3171

chenwany opened this issue Nov 15, 2021 · 1 comment · Fixed by #3841
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@chenwany
Copy link 

Admin:~/environment $ /home/ec2-user/.local/bin/pcluster create-cluster --cluster-name "hpc-1click-${CLUSTER_NAME}" --cluster-configuration cluster.config --rollback-on-failure false
b'!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n'
b'!!                                                                                  !!\n'
b'!!  This software has not been tested with node v17.0.1.                            !!\n'
b'!!  You may to encounter runtime issues, and should switch to a supported release.  !!\n'
b'!!                                                                                  !!\n'
b'!!  As of the current release, supported versions of node are:                      !!\n'
b'!!  - ^12.7.0                                                                       !!\n'
b'!!  - ^14.5.0                                                                       !!\n'
b'!!  - ^16.3.0                                                                       !!\n'
b'!!                                                                                  !!\n'
b'!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n'

Since we could not find any mention to this in the official docs we were wondering if there is any known compatibility issue with the latest Node version and/or if you plan to remove such warning from jsii.
@chenwany chenwany added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 15, 2021
@ryparker ryparker added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2021
@christophgysin christophgysin mentioned this issue Nov 1, 2022
Closed
2 tasks
RomainMuller added a commit that referenced this issue Nov 15, 2022
@RomainMuller
feat: allow silencing @jsii/check-node warnings
79572af 
Allows silencing @jsii/check-node warnings when the runtime is not
End-of-Life, so that users who know what they are doing can suppress
the extraneous output.

This is particularly useful for new Node releases that are un-tested,
but can typically be expected to work, or known broken releases that
happen to work for a given use-case that is carefully crafted to avoid
the known issues; but is also possible for deprecated node releases.

Messages about using end-of-life releases are intentionally not
suppressible.

Also updated the message for un-tested and known-broken releases to
better frame the fact that these might work fine, and urge users to
retry using a known supported release before they file a bug report.

Fixes #3817
Fixes #3171
@RomainMuller RomainMuller mentioned this issue Nov 15, 2022
Merged
RomainMuller added a commit that referenced this issue Nov 24, 2022
@RomainMuller
feat(check-node): allow silencing @jsii/check-node warnings (#3841)
880dbcc 
Allows silencing @jsii/check-node warnings when the runtime is not End-of-Life, so that users who know what they are doing can suppress the extraneous output.

This is particularly useful for new Node releases that are un-tested, but can typically be expected to work, or known broken releases that happen to work for a given use-case that is carefully crafted to avoid the known issues; but is also possible for deprecated node releases.

Messages about using end-of-life releases are intentionally not suppressible.

Also updated the message for un-tested and known-broken releases to better frame the fact that these might work fine, and urge users to retry using a known supported release before they file a bug report.

Additionally adds testing for Node 19.x.

Fixes #3817
Fixes #3171
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(check-node): allow silencing @jsii/check-node warnings aws/jsii
2 participants
@ryparker @chenwany