Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove use of private API #351

Merged
merged 4 commits into from
Feb 1, 2019
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 1, 2019

Don't use the upstream private API function to turn a CompilerHost into a
ParseConfigHost anymore; instead, I copied the implementation, which is
simple enough.

Fixes #350.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Until we can properly tackle #350, freeze the version of the
TypeScript compiler to a known-good version right now.
@rix0rrr rix0rrr requested a review from a team as a code owner February 1, 2019 09:31
@rix0rrr rix0rrr changed the title chore: Freeze TypeScript dependency fix: remove use of private API Feb 1, 2019
@@ -323,3 +323,18 @@ function nodeJsCompatibleSearchPaths(dir: string): string[] {

return ret;
}

function parseConfigHostFromCompilerHost(host: ts.CompilerHost): ts.ParseConfigHost {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the original implementation? I mean a permalink to the particular location... If it ever needs to be updated, that'll probably help track down where the new version of it lives...

@rix0rrr rix0rrr merged commit 874cbac into master Feb 1, 2019
@rix0rrr rix0rrr deleted the huijbers/freeze-typescript-dep branch February 1, 2019 12:53
RomainMuller added a commit that referenced this pull request Feb 4, 2019
### Bug Fixes
* remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350)
* **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341)
* **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401))
* **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345)

### Features
* **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c))
* Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
@RomainMuller RomainMuller mentioned this pull request Feb 4, 2019
RomainMuller added a commit that referenced this pull request Feb 4, 2019
### Bug Fixes
* remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350)
* **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341)
* **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401))
* **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345)

### Features
* **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c))
* Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants