Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce peer dependencies #361

Closed
RomainMuller opened this issue Feb 14, 2019 · 0 comments
Closed

Enforce peer dependencies #361

RomainMuller opened this issue Feb 14, 2019 · 0 comments
Assignees
@RomainMuller
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.

Comments

@RomainMuller
Copy link
Contributor

JSII modules should enforce that any dependency they take is also a peer dependency, as this is the least common denominator of all the runtimes that would be supported (aka it's the "easiest" way to manage dependencies).
@RomainMuller RomainMuller added the feature-request A feature should be added or improved. label Feb 14, 2019
@eladb eladb mentioned this issue Feb 17, 2019
Closed
@dstufft dstufft mentioned this issue Mar 28, 2019
Closed
RomainMuller added a commit that referenced this issue Apr 2, 2019
@RomainMuller
feat(jsii): Enforce use of peerDependencies
f265ea6 
Any direct dependency to another jsii module must be recorded as a
peerDependency as well, guaranteeing a consistent behavior of
dependencies across all possible jsii runtimes.

BREAKING CHANGE: All direct dependencies must be duplicated in
                 peerDependencies unless they are in bundledDependencies.

Fixes #361
@RomainMuller RomainMuller mentioned this issue Apr 2, 2019
Merged
RomainMuller added a commit that referenced this issue Apr 2, 2019
@RomainMuller
feat(jsii): Enforce use of peerDependencies (#421)
e72fea5 
Any direct dependency to another jsii module must be recorded as a
peerDependency as well, guaranteeing a consistent behavior of
dependencies across all possible jsii runtimes.

BREAKING CHANGE: All direct dependencies must be duplicated in
                 peerDependencies unless they are in bundledDependencies.

Fixes #361
@fulghum fulghum added the effort/small Small work item – less than a day of effort label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fulghum @RomainMuller