Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate dynamic type-checks in Python bindings #3639

Closed
RomainMuller opened this issue Jul 1, 2022 · 1 comment · Fixed by #3660
Closed

Generate dynamic type-checks in Python bindings #3639

RomainMuller opened this issue Jul 1, 2022 · 1 comment · Fixed by #3660
Assignees
@RomainMuller

Comments

@RomainMuller
Copy link
Contributor

Generate dynamic type-checking code as part of the generated bindings, so that users get language-specific error messages when they fail to comply with the type requirements of members.
@RomainMuller RomainMuller mentioned this issue Jul 13, 2022
Merged
@RomainMuller RomainMuller self-assigned this Jul 18, 2022
@mergify mergify bot closed this as completed in #3660 Jul 21, 2022
mergify bot pushed a commit that referenced this issue Jul 21, 2022
@RomainMuller
feat(python): add dynamic type checking (#3660)
6c4b773 
Use `typeguard` to perform runtime type checking of arguments passed
into methods (static or instance), setters, and constructors. This
ensures a pythonic error message is produced (and raised as a
`TypeError`), to help developers identify bugs in their code and fix
them.

These checks are disabled when running Python in optimized mode (via
`python3 -O`, which sets `__debug__` to false).

Fixes #3639 

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(python): add dynamic type checking aws/jsii
1 participant
@RomainMuller