Deprecation warnings not working for properties in a list of interfaces

[corymhall]

Describe the bug

When a property is deprecated, and that property is used in an interface that is part of a list, deprecation warnings (or failures) are not generated.

For example, cdk.aws_ec2.SubnetType.ISOLATED is deprecated, but if you use it as part of SubnetConfiguration like this:

new ec2.Vpc(this, 'Vpc', {
  subnetConfiguration: [
    {
      name: 'Isolated',
      subnetType: ec2.SubnetType.ISOLATED,
    },
  ],
});

warnings are not generated.

Expected Behavior

A warning should be generated:

[WARNING] @aws-cdk/aws-ec2.SubnetType#ISOLATED is deprecated.
  use `SubnetType.PRIVATE_ISOLATED`
  This API will be removed in the next major release. 

Current Behavior

No warning has been generated.

Reproduction Steps

Create a CDK v1 application.

npx aws-cdk@latest-1 init --language=typescript app

Create a VPC using a deprecated SubnetType:

import * as cdk from '@aws-cdk/core';
import * as ec2 from '@aws-cdk/aws-ec2';

export class CdkTmpV1Stack extends cdk.Stack {
  constructor(scope: cdk.Construct, id: string, props?: cdk.StackProps) {
    super(scope, id, props);

    new ec2.NatInstanceProvider({
      instanceType: ec2.InstanceType.of(ec2.InstanceClass.A1, ec2.InstanceSize.NANO),
      allowAllTraffic: true,
    });
    new ec2.Vpc(this, 'Vpc', {
      subnetConfiguration: [
        {
          name: 'public',
          subnetType: ec2.SubnetType.PUBLIC,
        },
        {
          name: 'Isolated',
          subnetType: ec2.SubnetType.ISOLATED,
        }
      ]
    })
  }
}

Run npx cdk synth

Possible Solution

It looks like we are not correctly handling cases where we deprecate properties that exist in a list of intefaces.

The function in .warnings.jsii.js

function _aws_cdk_aws_ec2_SubnetConfiguration(p) {
    if (p == null)
        return;
    visitedObjects.add(p);
    try {
        if (!visitedObjects.has(p.subnetType))
            _aws_cdk_aws_ec2_SubnetType(p.subnetType);
    }
    finally {
        visitedObjects.delete(p);
    }
}

Should be something like

function _aws_cdk_aws_ec2_SubnetConfiguration(p) {
    if (p == null)
        return;
    visitedObjects.add(p);
    try {
        p.forEach(config => {
          if (!visitedObjects.has(config.subnetType))
              _aws_cdk_aws_ec2_SubnetType(config.subnetType);
        });
    }
    finally {
        visitedObjects.delete(p);
    }

Additional Information/Context

Original issue aws/aws-cdk#22066

SDK version used

CDK v1.172.0

Environment details (OS name and version, etc.)

Ubuntu

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.