fix(python): returning Promise<void> breaks runtime #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `EndResponse` struct did not supply a default value for the `result` property, making it required (despite it is typed `Any`, which `None` is valid for). Fix the schema to represent as `Optional[Any] = None` and add a compliance test to validate this scenario. Note for readers here - async support is very much experimental and only partially imported in most jsii front-end languages. Caution is still advised if you are going to expose async APIs.
mrgrain
approved these changes
Jan 19, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EndResponsestruct did not supply a default value for theresultproperty, making it required (despite it is typedAny, whichNoneis valid for). Fix the schema to represent asOptional[Any] = Noneand add a compliance test to validate this scenario.Note for readers here - async support is very much experimental and only partially imported in most jsii front-end languages. Caution is still advised if you are going to expose async APIs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.