fix(rosetta): prints colors to log file #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosetta error messages contain colors codes in the errors, which makes the errors produced by Rosetta look like garbage and very hard to parse. Strip the colors if we detect a non-TTY input. (Copied the regex from an MIT-licensed package to avoid adding extra dependencies)
RomainMuller
approved these changes
Feb 14, 2023
Comment on lines
+247
to
+257
| const ANSI_PATTERN = new RegExp( | ||
| [ | ||
| '[\\u001B\\u009B][[\\]()#;?]*(?:(?:(?:(?:;[-a-zA-Z\\d\\/#&.:=?%@~_]+)*|[a-zA-Z\\d]+(?:;[-a-zA-Z\\d\\/#&.:=?%@~_]*)*)?\\u0007)', | ||
| '(?:(?:\\d{1,4}(?:;\\d{0,4})*)?[\\dA-PR-TZcf-nq-uy=><~]))', | ||
| ].join('|'), | ||
| 'g', | ||
| ); | ||
|
|
||
| function stripColorCodes(x: string) { | ||
| return x.replace(ANSI_PATTERN, ''); | ||
| } |
There was a problem hiding this comment.
(Copied the regex from an MIT-licensed package to avoid adding extra dependencies)
Still, it would not hurt to attribute to the original package/authors?
RomainMuller
added
the
pr/do-not-merge
|
Added do-not-merge as I'd still like the attribution to be added... |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
rix0rrr
added a commit
to aws/jsii-rosetta
that referenced
this pull request
Apr 12, 2023
Rosetta error messages contain colors codes in the errors, which makes the errors produced by Rosetta look like garbage and very hard to parse. Strip the colors if we detect a non-TTY input. (Copied the regex from an MIT-licensed package to avoid adding extra dependencies) Port of aws/jsii#3953
aws-cdk-automation
pushed a commit
to aws/jsii-rosetta
that referenced
this pull request
Apr 12, 2023
Rosetta error messages contain colors codes in the errors, which makes the errors produced by Rosetta look like garbage and very hard to parse. Strip the colors if we detect a non-TTY input. (Copied the regex from an MIT-licensed package to avoid adding extra dependencies) Port of aws/jsii#3953 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosetta error messages contain colors codes in the errors, which makes the errors produced by Rosetta look like garbage and very hard to parse.
Strip the colors if we detect a non-TTY input.
(Copied the regex from an MIT-licensed package to avoid adding extra dependencies)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.