fix(jsii-reflect): don't load same assembly multiple times #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deCDK tests were calling `loadModule()` for every package. `loadModule()` did have some recursion avoidance INSIDE one call, but not across multiple load calls on the same type system. This brings down the deCDK tests from 80s to 10s. Add an option to disable validation, which would bring the full CDK typesystem loading down from 10s to 600ms (validation is enabled by default). Some more type exposure updates so that we can update awslint and friends in the CDK repository to take advantage of the new jsii model.
eladb
approved these changes
Apr 16, 2019
| */ | ||
| public async load(fileOrDirectory: string) { | ||
| public async load(fileOrDirectory: string, validate = true) { |
There was a problem hiding this comment.
Prefer keyword arguments: { validate: true }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deCDK tests were calling
loadModule()for every package.loadModule()did have some recursion avoidance INSIDE one call,but not across multiple load calls on the same type system.
This brings down the deCDK tests from 80s to 10s.
Add an option to disable validation, which would bring the full CDK
typesystem loading down from 10s to 600ms (validation is enabled
by default).
Some more type exposure updates so that we can update awslint
and friends in the CDK repository to take advantage of the new
jsii model.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.