Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii-reflect): don't load same assembly multiple times #461

Merged
merged 5 commits into from
Apr 16, 2019
Merged

fix(jsii-reflect): don't load same assembly multiple times #461

merged 5 commits into from
Apr 16, 2019

Commits on Apr 16, 2019

  1. fix(jsii-reflect): don't load same assembly multiple times 

    deCDK tests were calling `loadModule()` for every package.
`loadModule()` did have some recursion avoidance INSIDE one call,
but not across multiple load calls on the same type system.

This brings down the deCDK tests from 80s to 10s.

Add an option to disable validation, which would bring the full CDK
typesystem loading down from 10s to 600ms (validation is enabled
by default).

Some more type exposure updates so that we can update awslint
and friends in the CDK repository to take advantage of the new
jsii model.
    Rico Huijbers committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    0e99622 View commit details
    Browse the repository at this point in the history

  2. Speed up Java build from around 30s to around 10s per package

    Rico Huijbers committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    b77a5ca View commit details
    Browse the repository at this point in the history

  3. Fix roots test, make keyword args

    Rico Huijbers committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    d00e36a View commit details
    Browse the repository at this point in the history

  4. Fix breaking API

    Rico Huijbers committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    9e06f58 View commit details
    Browse the repository at this point in the history

  5. Update expectations

    Rico Huijbers committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    24a790f View commit details
    Browse the repository at this point in the history