Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsii: also erase base types that exported from their module, but the module is not #524

Closed
rix0rrr opened this issue Jun 7, 2019 · 1 comment
Labels
bug This issue is a bug. closed-for-staleness effort/large Large work item – several weeks of effort p2

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 7, 2019

Classes that are exported from their module, but the module is not exported from the package should be erased as well.

Currently, they are not erased, and then the validation throws an error.

Marking them as @internal does not suffice, because then other TypeScript libraries can no longer use the package (since subclasses will still be declared as extendsing the hidden class, that is not written to a .d.ts file).

@rix0rrr rix0rrr added the bug This issue is a bug. label Jun 7, 2019
@RomainMuller RomainMuller added the p2 label Jan 9, 2020
@RomainMuller RomainMuller added the effort/large Large work item – several weeks of effort label Aug 11, 2020
@RomainMuller RomainMuller removed their assignment Jun 24, 2021
@github-actions
Copy link
Contributor

This issue has not received any attention in 2 years. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. closed-for-staleness effort/large Large work item – several weeks of effort p2
Projects
None yet
Development

No branches or pull requests

2 participants