fix(.net): occasional incorrect param type cast #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When structures (as literal JSON blocks) get passed through a "map" argument, a `JObject` would be passed to the method despite the declared type on the .NET code is `IDictionary`, resulting in a crash. This code forcefully converts `JObject` to `IDictionary<string, objetc>` in such code paths. Fixes aws/aws-cdk#3093
ghost
requested a review
from 
eladb
suggested changes
Jul 1, 2019
packages/jsii-dotnet-runtime/src/Amazon.JSII.Runtime/Amazon.JSII.Runtime.sln
Outdated
Show resolved
Hide resolved
packages/jsii-dotnet-runtime/src/Amazon.JSII.Runtime/CallbackExtensions.cs
Show resolved
Hide resolved
packages/jsii-dotnet-runtime-test/test/Amazon.JSII.Runtime.IntegrationTests/ComplianceTests.cs
Show resolved
Hide resolved
eladb
reviewed
Jul 1, 2019
eladb
approved these changes
Jul 1, 2019
|
I'm provisionally waiting to see if @garnaat can teach me how to do Python right before merging this. If we don't get around to it fast enough, I'll be fixing the Python test in a separate PR 🤞🏻 |
|
Talked with @garnaat offline and managed to get the test to work. Whee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When structures (as literal JSON blocks) get passed through a "map"
argument, a
JObjectwould be passed to the method despite the declaredtype on the .NET code is
IDictionary, resulting in a crash.This code forcefully converts
JObjecttoIDictionary<string, objetc>in such code paths.
Fixes aws/aws-cdk#3093
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.