Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(.net): occasional incorrect param type cast #568

Merged
merged 6 commits into from
Jul 1, 2019
Merged

fix(.net): occasional incorrect param type cast #568

merged 6 commits into from
Jul 1, 2019

Commits on Jul 1, 2019

  1. fix(.net): occasional incorrect param type cast 

    When structures (as literal JSON blocks) get passed through a "map"
argument, a `JObject` would be passed to the method despite the declared
type on the .NET code is `IDictionary`, resulting in a crash.

This code forcefully converts `JObject` to `IDictionary<string, objetc>`
in such code paths.

Fixes aws/aws-cdk#3093
    @RomainMuller
    RomainMuller committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    dfdddd6 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary file

    @RomainMuller
    RomainMuller committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    7b148f9 View commit details
    Browse the repository at this point in the history

  3. add explanatory comment

    @RomainMuller
    RomainMuller committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    9ade050 View commit details
    Browse the repository at this point in the history

  4. add other languages tests

    @RomainMuller
    RomainMuller committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    8f38de0 View commit details
    Browse the repository at this point in the history

  5. fix the python test and un-skip it

    @RomainMuller
    RomainMuller committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    64f864d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into rmuller/fix-dotnet

    @RomainMuller
    RomainMuller committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    2121324 View commit details
    Browse the repository at this point in the history