-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dotnet): fix deep type conversion across the process boundary, intelisense docs, set target to netcoreapp2.1 #772
Conversation
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
Please update PR description and title so this will be reviewable |
The description for "fix" should describe the root cause |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
private bool TryConvertCollectionElement(object element, IReferenceMap referenceMap, TypeReference elementType, | ||
out object convertedElement) | ||
{ | ||
bool converted; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we just return directly instead of having temporary variables and a break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This can be squashed and merged, double approved. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR fixes various issues due to how we convert collection elements, and how the type reference is passed when converting.
These two issues are similar and are due to nested Arrays of object not being casted properly:
Fixes aws/aws-cdk#3244
Fixes aws/aws-cdk#3672
Added a unit test to cover the case
This issue is due to Maps of Arrays of Anys not being casted properly:
Fixes aws/aws-cdk#3813
Added a unit test to cover the case
Also added support for xml documentation which is now added to the NuGet packages and should allow intellisense to provide in IDE help:
Fixes #749
Fixes aws/aws-cdk#1846
Migrated the target framework to netcoreapp2.1 instead of netstandard2.0:
Fixes #714
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.