fix(pacmak): occasional EISDIR failure #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a race condition in capturing the output of `npm pack`. Ocassionally we would miss the output, not get a tarball name, combine the empty string with a directory, and then get an EISDIR error when trying to copy the tarball as a file (but giving it a directory name). This race has been in there forever, but it became easier to trigger since we started running a lot of `npm pack`s in parallel. The solution is to wait for a different event on the `ChildProcess` object.
eladb
approved these changes
Nov 6, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition in capturing the output of
npm pack.Ocassionally we would miss the output, not get a tarball name, combine
the empty string with a directory, and then get an EISDIR error when
trying to copy the tarball as a file (but giving it a directory name).
This race has been in there forever, but it became easier to trigger
since we started running a lot of
npm packs in parallel.The solution is to wait for a different event on the
ChildProcessobject.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.