Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pacmak): occasional EISDIR failure #948

Merged
merged 2 commits into from
Nov 6, 2019
Merged

fix(pacmak): occasional EISDIR failure #948

merged 2 commits into from
Nov 6, 2019

Commits on Nov 6, 2019

  1. fix(pacmak): occasional EISDIR failure 

    There was a race condition in capturing the output of `npm pack`.
Ocassionally we would miss the output, not get a tarball name, combine
the empty string with a directory, and then get an EISDIR error when
trying to copy the tarball as a file (but giving it a directory name).

This race has been in there forever, but it became easier to trigger
since we started running a lot of `npm pack`s in parallel.

The solution is to wait for a different event on the `ChildProcess`
object.
    Rico Huijbers committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    684903b View commit details
    Browse the repository at this point in the history

  2. Update util.ts

    Elad Ben-Israel committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    da5aebb View commit details
    Browse the repository at this point in the history