fix: @jsii/check-node crashes on loading with older node releases #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was built with ES2020 target, which fails to load with Node 10 and 12 as it makes use of the ?? syntax, which is not available in those releases. Changing the TypeScript target so that code continues to load in older node releases.
RomainMuller
force-pushed
the
rmuller/check-node-older
branch
from
5e97ae7
to
839386c
Compare
RomainMuller
added a commit
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was built with ES2020 target, which fails to load with Node 10 and 12 as
it makes use of the
??syntax, which is not available in those releases.Changing the TypeScript target so that code continues to load in older node
releases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.