fix(jsii): detect double interface member declarations #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C# it's prohibited to declare an interface member that also exists in an inherited interface. Have jsii detect this illegal pattern. Strictly speaking, this only true if we don't overload, but since we don't support overloading anyway we just check on the member names, not the types. Fixes #340.
eladb
approved these changes
Feb 13, 2019
costleya
reviewed
Feb 13, 2019
| @@ -624,6 +624,27 @@ export class Assembler implements Emitter { | |||
| } | |||
| }); | |||
|
|
|||
| // Check that no interface declares a member that's already declared | |||
| // in a base type (not allowed in C#). | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Well this is the error I get:
@aws-cdk/aws-iam: IRoleProxy.cs(113,21): error CS0111: Type 'IRoleProxy' already defines a member called 'AddToPolicy' with the same parameter types [/tmp/jsii-pacmak-codec20iQw/Amazon.CDK.AWS.IAM/Amazon.CDK.AWS.IAM.csproj]
There was a problem hiding this comment.
Yeah I guess 'new' will do it. I don't get the point of it though, and our C# generator doesn't do the necessary analysis to add the modifier, so I think disallowing in jsii is the easiest way forward.
RomainMuller
added a commit
that referenced
this pull request
Feb 27, 2019
### Bug Fixes * **jsii-pacmack:** default to target directory mode ([#363](#363)) ([967d917](967d917)) * **java-runtime:** Bump version of Jackson because of CVEs ([#362](#362)) ([140aa4d](140aa4d)) * **jsii:** detect double interface member declarations ([#360](#360)) ([b2b2c89](b2b2c89)), closes [#340](#340)
RomainMuller
added a commit
that referenced
this pull request
Feb 27, 2019
### Bug Fixes * **jsii-pacmack:** default to target directory mode ([#363](#363)) ([967d917](967d917)) * **java-runtime:** Bump version of Jackson because of CVEs ([#362](#362)) ([140aa4d](140aa4d)) * **jsii:** detect double interface member declarations ([#360](#360)) ([b2b2c89](b2b2c89)), closes [#340](#340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C# it's prohibited to declare an interface member
that also exists in an inherited interface. Have jsii
detect this illegal pattern.
Strictly speaking, this only true if we don't overload,
but since we don't support overloading anyway we just
check on the member names, not the types.
Fixes #340.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.